GHA Docker image building setup#17
Merged
Merged
Conversation
mclasmeier
force-pushed
the
mc/docker-img-building-gha
branch
2 times, most recently
from
4401550 to
f60de95
Compare
added 6 commits
December 15, 2025 14:46
Otherwise -- if not present -- docker will prepend some docker.io/.... registry automatically. This change makes the resulting image be the same when using docker or podman.
mclasmeier
force-pushed
the
mc/docker-img-building-gha
branch
from
f953eb3 to
7e8b889
Compare
tommartensen
requested changes
Dec 15, 2025
Collaborator
tommartensen
left a comment
tommartensen
left a comment
There was a problem hiding this comment.
I have reviewed the first two commits.
Collaborator
tommartensen
left a comment
tommartensen
left a comment
There was a problem hiding this comment.
Finished review of everything except the README.
Will do once the other changes are addressed.
added 5 commits
December 16, 2025 13:13
…up. Remove coupled of unneeded Makefile targets.
Collaborator
Author
|
@tommartensen Thank you! Hope I have addressed everything! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR can be reviewed commit-by-commit.
It essentially integrates image building and pushing into GHA.
Related to that, it improves the version string generation in the
Makefile, deriving the version string to be compiled into the binary and used for docker images from existing Git tags.